Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added REACT_EDITOR to Advanced Configuration section #2445

Merged
merged 3 commits into from
Jun 27, 2017

Conversation

wirmar
Copy link
Contributor

@wirmar wirmar commented Jun 1, 2017

#2406

Should I also add a new section to the User Guide?

@Timer
Copy link
Contributor

Timer commented Jun 18, 2017

Hi! I'm going to hold off on merging this temporarily as we're probably going to land #2552 soon.

@levrik
Copy link
Contributor

levrik commented Jun 27, 2017

@Timer #2552 just landed for 1.0.8

@gaearon gaearon added this to the 1.0.8 milestone Jun 27, 2017
@gaearon
Copy link
Contributor

gaearon commented Jun 27, 2017

Thanks! I tweaked the wording a little bit.

@gaearon gaearon merged commit 6a09ed1 into facebook:master Jun 27, 2017
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
…k#2445)

* docs: added REACT_EDITOR to `Advanced Configuration` section

* Update README.md

* Update launchEditor.js
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
* docs: added REACT_EDITOR to `Advanced Configuration` section

* Update README.md

* Update launchEditor.js
morgs32 pushed a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017
…k#2445)

* docs: added REACT_EDITOR to `Advanced Configuration` section

* Update README.md

* Update launchEditor.js
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants